Fix crash when assigning to bool class fields#95
Fix crash when assigning to bool class fields#95dcodeIO merged 1 commit intoAssemblyScript:masterfrom
Conversation
|
@dcodeIO I see that the |
|
|
|
Got it, so the contributing docs (https://github.com/AssemblyScript/assemblyscript/blob/master/CONTRIBUTING.md#submitting-pull-requests) are out of date? I guess when this project gets published to npm, WebAssembly Studio can just use that instead of relying on dist files in the repo? |
|
This better ask to @dcodeIO. |
alangpierce
force-pushed
the
fix-bool-assignment-crash
branch
from
03e106c to
6fd2539
Compare
|
Ok, I updated the commit to include dist file updates as well (just the result of |
|
Oh, funny, the build failed with "The pull request includes changes to distribution files, but it shouldn't." I'll leave them out I suppose. |
alangpierce
force-pushed
the
fix-bool-assignment-crash
branch
from
6fd2539 to
9046e97
Compare
|
No, you should exclude dist files) So everything was alright before
|
Fixes AssemblyScript#94 With `Type.bool`, size is 1, so dividing by 8 isn't the right way to convert to byteSize. Instead, we need to use the `byteSize` property that does the proper ceiling division. I left out the allocation from the test so that the resulting wat files are easier to read.
alangpierce
force-pushed
the
fix-bool-assignment-crash
branch
from
9046e97 to
e3ffa4e
Compare
|
@dcodeIO updated to include a load in the test case as well. |
|
Thank you! :) |
3 participants
Fixes #94
With
Type.bool, size is 1, so dividing by 8 isn't the right way to convert tobyteSize. Instead, we need to use the
byteSizeproperty that does the properceiling division.
I left out the allocation from the test so that the resulting wat files are
easier to read.